Skip to content

Commit

Permalink
Green CI, FU windows!
Browse files Browse the repository at this point in the history
  • Loading branch information
zakstucke authored Jan 26, 2024
1 parent 339dd70 commit 19060a9
Show file tree
Hide file tree
Showing 25 changed files with 1,213 additions and 404 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,6 @@ jobs:
uses: actions/setup-node@v2
with:
node-version: "20"
cache: npm
cache-dependency-path: "js/package-lock.json"

- name: Build docs
run: |
Expand Down Expand Up @@ -218,8 +216,6 @@ jobs:
uses: actions/setup-node@v2
with:
node-version: "20"
cache: npm
cache-dependency-path: "js/package-lock.json"

- name: Install deps, build lib and copy package.json and README.md to dist which is published as root
run: |
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/release.yml.zetch
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,6 @@ jobs:
uses: actions/setup-node@v2
with:
node-version: "20"
cache: npm
cache-dependency-path: 'js/package-lock.json'

- name: Build docs
run: |
Expand Down Expand Up @@ -225,8 +223,6 @@ jobs:
uses: actions/setup-node@v2
with:
node-version: "20"
cache: npm
cache-dependency-path: 'js/package-lock.json'

- name: Install deps, build lib and copy package.json and README.md to dist which is published as root
run: |
Expand Down
23 changes: 18 additions & 5 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,9 @@ jobs:
uses: actions/setup-node@v2
with:
node-version: "20"
cache: npm
cache-dependency-path: "js/package-lock.json"

- name: Install rust toolchain
uses: dtolnay/rust-toolchain@stable

- name: Install dependencies
run: |
Expand Down Expand Up @@ -220,7 +221,13 @@ jobs:
needs: whos_changed
# Only run if applicable things have changed:
if: needs.whos_changed.outputs.rust-changed == 'true'
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
# Run on both linux and windows (dev testing on mac and much more expensive in terms of build minutes),
# windows most likely to fail unexpectedly.
os: [ubuntu-latest, windows-latest]
steps:
- uses: actions/checkout@v4

Expand All @@ -232,6 +239,12 @@ jobs:
with:
workspaces: "./rust -> target"

- name: Run tests
- name: Run tests (linux)
if: matrix.os == 'ubuntu-latest'
run: |
./dev_scripts/test.sh rust --no-fail-fast
- name: Run tests (windows)
if: matrix.os == 'windows-latest'
run: |
./dev_scripts/test.sh rust
bash ./dev_scripts/test.sh rust --no-fail-fast
26 changes: 13 additions & 13 deletions .zetch.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 19060a9

Please sign in to comment.