Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore version checking if building latest tag. #19

Merged
merged 1 commit into from
May 27, 2019
Merged

Conversation

bmaher
Copy link
Contributor

@bmaher bmaher commented May 22, 2019

Part of #6.

Description

This PR fixes a bug where Travis CI builds tags after merges to master, resulting in a failure in the version checking script (versions matched between master and tag).

Instructed Travis to ignore all branches matching a regex representing tags /^v\d+\.\d+(\.\d+)?(-\S*)?$/.

Types of Changes

What types of changes does your code introduce? Keep the ones that apply:

  • Configuration change

Review

Reviewers' checklist:

  • If this PR implements new flows or changes existing ones, are there
    good tests for these flows?
    If this PR rather removes flows, are the obsolete tests removed as well?
  • Is the documentation still up-to-date and exhaustive? This covers both
    technical (in source files) and functional (under docs/) documentation.
  • Is the changelog updated?
  • Does the new version number correspond to the actual changes from this PR?
    In doubt, refer to https://semver.org.

After this PR

Any follow-up action necessary?

@zincr
Copy link

zincr bot commented May 22, 2019

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

@bmaher bmaher requested review from tortila and thilp May 22, 2019 14:37
Copy link
Contributor

@tortila tortila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there's an easier solution to this problem - perhaps we could just skip builds from tags? I found this feature of Travis: https://docs.travis-ci.com/user/customizing-the-build/#safelisting-or-blocklisting-branches that explains this exact use case. What do you think @bmaher @thilp?

Signed-off-by: Brian Maher <[email protected]>
@bmaher bmaher merged commit d32d3d0 into master May 27, 2019
@bmaher bmaher deleted the fix_tag_builds branch May 27, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants