Make kafka startup timeout configurable #58
Conversation
| ``` | ||
| # Linear timeout configuration | ||
| # initial timeout=300 seconds, after each failed start increase by 60 seconds (360, 420 and so on) | ||
| export STARTUP_TIMEOUT="type=linear:initial=300:step=60" |
There was a problem hiding this comment.
is that some standard format? For me it looks hacky
There was a problem hiding this comment.
Well, it's not standard, but I wanted to introduce a lot of different parameters...
There was a problem hiding this comment.
STARTUP_TIMEOUT_TYPE
STARTUP_TIMEOUT_INITIAL
STARTUP_TIMEOUT_STEP
?
There was a problem hiding this comment.
@v-stepanov Well, my previous comment is really strange.
There are 2 types of startup timeout: linear and progressive. And they have different parameters - step and scale. I wanted to encapsulate this information to a single parameter, because STARTUP_TIMEOUT_STEP will not have any meaning for progressive timeout.
That means that STARTUP_TIMEOUT_STEP (SCALE) depends on STARTUP_TIMEOUT_TYPE. I wanted to have this information in one place, because having step and scale defined in the same time may lead to confusion, but having it defined in the same parameter won't have this problem, and it's simpler to understand what is the real configuration
There was a problem hiding this comment.
But you can just keep the name STARTUP_TIMEOUT_STEP for both modes.
I think having some custom complex structure for parameter value is very bad. I think the only thing that is acceptable is a list of items separate by ",".
And having parameters that depend on each other is fine for me, we can't really avoid that. At least they have the same prefix "STARTUP_TIMEOUT_"
There was a problem hiding this comment.
@v-stepanov Ok. I agree
|
Do you think it's already time to start writing integration tests? :) |
|
In general |
|
|
||
| class TestDataSizeStats(unittest.TestCase): | ||
| def test_linear_defaults(self): | ||
| o = StartupTimeout.build({'type': 'linear'}) |
Closes #56