This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Handle network errors in proper way #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def get_aws_region(self) -> str: | ||
| doc = self._get_document() | ||
| return doc['region'] if doc else None | ||
| document = requests.get('http://{}/latest/dynamic/instance-identity/document'.format(self.aws_addr), |
There was a problem hiding this comment.
What is this magic endpoint?
And what is the magic address '169.254.169.254'?
There was a problem hiding this comment.
|
@v-stepanov @rcillo @adyach @v1ctor Are there any other suggestions? This bugfix is really important. |
|
@antban Hey any chance of a new release with this fix? We're using bubuku ourselves, and seen some strange problems, and would like to know if the recent fixes clear the problems up. Thanks, H |
|
@retnuh Wow, lost this comment. I plan to release on Monday evening (19.09) or 20.09. The thing is that I want to include optimized rebalancing. It's one of the important features. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or at least allow to recover after it. Fixes #59