This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Ability to list and cancel running (and queued) actions of bubuku #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adyach
reviewed
Sep 20, 2016
| _print_table(table) | ||
|
|
||
|
|
||
| @actions.command('delete', help='List all the actions on broker(s)') |
adyach
reviewed
Sep 20, 2016
| @click.option('--action', type=click.STRING, | ||
| help='Action to delete') | ||
| @click.option('--broker', type=click.STRING, | ||
| help='Broker id to list actions on. By default all brokers are enumerated') |
v-stepanov
reviewed
Sep 20, 2016
| @@ -100,6 +102,91 @@ def swap_partitions(threshold: int): | |||
| RemoteCommandExecutorCheck.register_fatboy_slim(zookeeper, threshold_kb=threshold) | |||
|
|
|||
|
|
|||
| @cli.group(name='actions', help='Work with running actions') | |||
There was a problem hiding this comment.
@v-stepanov I don't fully get the question. It's group description if you run bubuku-cli actions
There was a problem hiding this comment.
What does group description do?
v-stepanov
reviewed
Sep 20, 2016
| finish = cur_time + (0.1 if timeout <= 0 else timeout) | ||
| while cur_time < finish: | ||
| try: | ||
| commnad = __COMMAND_QUEUE.get(block=True, timeout=finish - cur_time) |
There was a problem hiding this comment.
@v-stepanov fixed ff19b75
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61 #62