-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Spring Boot 3 #190
base: master
Are you sure you want to change the base?
Conversation
@ePaul I wanted to trigger a build with a GH action but I guess the PR needs to be merged first for the |
| Spring Boot | nakadi-producer-spring-boot-starter | | ||
|---|---| | ||
| 3.x | >= 30.0.0 | | ||
| 2.x | >= 20.0.0 but < 30.0.0 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So there is no way of having a version of the library which works with both Spring boot 2 and 3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in my understanding - the 'small' changes in Spring Boot 3 (namely the Jakarta EE 10 + Flyway 9 adoption, and the lack of support for the old way of specifying autoconfiguration) are incompatible between the two versions.
Hmm, not sure. I don't see any button like "run checks". Maybe you can submit the changes to set up a CI separately? |
In that case I might just wait for that then (also volunteer to help with the move) - otherwise the PR now would have to initially run a build with JDK 11, that would cause a merge conflict here, etc.. too much hassle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just was looking at this again, and noticed that this test isn't actually executed when building the project (e.g. with mvnw clean install
).
I was just going to complain, but then I also ran the build in master, and found that the test isn't run spring-boot 2 either :-/
I don't remember anymore whether we intentionally disabled this to get the build running faster ... but in effect I can't get it to run now. Any ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't try to fix this myself (could try later if needed) but it smells to me like mixup between JUnit 4 and 5 (and/or JUnit 4 vs. recent Spring Boot issues) - I faced similar things in the past and it was related to that (the fix was to move everything to JUnit 5 instead of having this versions spaghetti (e.g. get rid of @RunWith(SpringRunner)
in favor of only @SpringBootTest
, etc)
What's changed
META-INF
path changed)javax.*
imports with correspondingjakarta.*
onesnakadi-producer-starter-spring-boot-2-test
->nakadi-producer-starter-spring-boot-3-test
org.postgresql
as it's already covered in other dependency30.0.0-SNAPSHOT
Notes