omit metadata.partition_compaction_key if null #193
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #164, support for compacted event types was introduced.
This was implemented by adding a new nullable property to the NakadiMetadata class.
It turns out that for the value null (which is the default if no compaction key extractor is configured), depending on the configuration of the used object mapper, a
"partition_compaction_key": nullis included in the JSON stream. Nakadi will reject such event submissions for non-compacted event types.This change is meant to tell Jackson to exclude this property if null, even if the mapper configuration says something else.
TODO: we should get some tests for this.