Skip to content
This repository has been archived by the owner on Jan 7, 2022. It is now read-only.

Set secure flag for the session cookie #147

Merged
merged 2 commits into from
May 26, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ exports = module.exports = function createConfiguration(env) {
//maxAge: 60000, // duration of the cookie in milliseconds, defaults to duration above (cannot be used if 'ephemeral: true')
ephemeral: true, // when true, cookie expires when the browser closes (cannot be used with 'maxAge')
httpOnly: true, // when true, cookie is not accessible from javascript
secure: false // when true, cookie will only be sent over SSL. use key 'secureProxy' instead if you handle SSL not in your node process
secureProxy: true // we want our session cookie to be secure and we assert that SSL is handled externally (in our case with skipper)
}
},

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/config.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ describe('Config', function() {
path: '/',
ephemeral: true,
httpOnly: true,
secure: false
secureProxy: true
}
},
credentialsDir: 'deploy/OAUTH'
Expand Down