Skip to content
This repository has been archived by the owner on Jan 7, 2022. It is now read-only.

Change default owning application for event type, query create to an empty value #151

Merged
merged 4 commits into from
Sep 9, 2021

Conversation

antban
Copy link
Contributor

@antban antban commented Sep 1, 2021

There is no meaning in having default value that users have to constantly override.

@a1exsh
Copy link
Contributor

a1exsh commented Sep 1, 2021

What about subscriptions? They are rarely created manually I guess, but I see no reason to keep it there either.

@antban
Copy link
Contributor Author

antban commented Sep 8, 2021

👍

@a1exsh
Copy link
Contributor

a1exsh commented Sep 8, 2021

Unsuprisingly, the tests expect these fields to be set:

Failures:
1) Create Event type form should submit default data (happy scenario)
  Message:
    Failed: element not interactable
  Stack:
    Error: An element command could not be completed because the element is not visible on the page.
        at elementIdClick("0.21471385270509247-4") - click.js:20:22
2) Create Subscription form should submit default data (happy scenario)
  Message:
    Expected false to be truthy 'Submit btn should be enabled if name is set'.
...

@antban
Copy link
Contributor Author

antban commented Sep 9, 2021

Who-ho! The tests are passing!

@antban
Copy link
Contributor Author

antban commented Sep 9, 2021

👍

1 similar comment
@a1exsh
Copy link
Contributor

a1exsh commented Sep 9, 2021

👍

@antban antban merged commit 4e29869 into master Sep 9, 2021
@antban antban deleted the default-owning-app-remove branch September 9, 2021 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants