This repository has been archived by the owner on Apr 22, 2020. It is now read-only.
make dns_traffic independent from stackname-stackversion for ELBs #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- one call per run more
- new instances might be updated every time
- also:
* change image data to be a dict {'id': ..., 'name': ..., 'date':
...}, we might want to add more keys later.
Conflicts: zmon_aws_agent/aws.py
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 77.41% 77.49% +0.07%
==========================================
Files 6 6
Lines 642 662 +20
==========================================
+ Hits 497 513 +16
- Misses 145 149 +4
Continue to review full report at Codecov.
|
|
👍 |
|
👍 |
|
not needed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial fix for #112: map the ELB dns_name to the route53 DNS name