Use try with resources for file system #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason for the switch from visitor to stream? |
Nothing major. I think the visitor is not that common nowadays, so streams might make the code easier to read. |
Comment on lines
+65
to
+67
| final Path jarPath = fileSystem.getPath(resourcePath); | ||
|
|
||
| try (Stream<Path> stream = Files.walk(jarPath)) { |
There was a problem hiding this comment.
Suggested change
| final Path jarPath = fileSystem.getPath(resourcePath); | |
| try (Stream<Path> stream = Files.walk(jarPath)) { | |
| try (Stream<Path> stream = Files.walk(fileSystem.getPath(resourcePath))) { |
There was a problem hiding this comment.
You don't use the variable later, so why actually assign it at all?!
There was a problem hiding this comment.
You don't use the variable later, so why actually assign it at all?!
Would be nice, but it's actually used (in lines 72 and 77).
There was a problem hiding this comment.
So much for my eyesight. 😏
cberg-zalando
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #332 - close file system also in case an exception is thrown. Unlikely to be an actual fix, but at least should rule out earlier failures as a cause.
Also switch from a visitor to a stream.