Bump multiple dependencies #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MALPI
requested review from
whiskeysierra,
lukasniemeier-zalando and
AlexanderYastrebov
as code owners
This was referenced Jan 6, 2023
MALPI
changed the title
|
👍 |
|
@danielrohe please take a look |
|
Does it make sense to adjust specific versions. This library will only run as part of another application where developers will manage versions using either spring boot, do it manually or use any other kind of dependency management tool. With this they will override the versions which are set in this pom.xml. So do we need to do the effort in bumping versions in a library? |
|
You need to find a way to test this library against newer versions of its dependencies. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump version of
Upgrade the dependency check plugin in order to make it work again.
As Spring and transitive dependencies like snakeyaml and others come with CVE's that are considered false positives I deactivated for now the failing build on cve.
Moreover I filed #832 in order to remove the plugin.