Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding jaxb-api dependency to address coveralls-maven-plugin error #967

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bocytko
Copy link
Member

@bocytko bocytko commented Feb 14, 2025

Description

Adds jaxb-api as dependency to address build error:

[ERROR] Failed to execute goal org.eluder.coveralls:coveralls-maven-plugin:4.3.0:report (default-cli) on project solid: Execution default-cli of goal org.eluder.coveralls:coveralls-maven-plugin:4.3.0:report failed: A required class was missing while executing org.eluder.coveralls:coveralls-maven-plugin:4.3.0:report: javax/xml/bind/DatatypeConverter

Motivation and Context

trautonen/coveralls-maven-plugin#141

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Build log after fix

Adding as coverage submission is skipped on CI.

[INFO]
[INFO] --- coveralls-maven-plugin:4.3.0:report (default-cli) @ problem-spring-parent ---
[INFO] Starting Coveralls job
[INFO] Using repository token <secret>
[INFO] Git commit 98a3acf in fix-build
[INFO] Writing Coveralls data to /Users/bartek/repos/problem-spring-web/target/coveralls.json...
[INFO] Processing coverage report from /Users/bartek/repos/problem-spring-web/problem-violations/target/site/jacoco/jacoco.xml
[INFO] Processing coverage report from /Users/bartek/repos/problem-spring-web/problem-spring-common/target/site/jacoco/jacoco.xml
[INFO] Processing coverage report from /Users/bartek/repos/problem-spring-web/problem-spring-web/target/site/jacoco/jacoco.xml
[INFO] Processing coverage report from /Users/bartek/repos/problem-spring-web/problem-spring-web-autoconfigure/target/site/jacoco/jacoco.xml
[INFO] Processing coverage report from /Users/bartek/repos/problem-spring-web/problem-spring-webflux/target/site/jacoco/jacoco.xml
[INFO] Successfully wrote Coveralls data in 71ms
[INFO] Gathered code coverage metrics for 86 source files with 3234 lines of code:
[INFO] - 398 relevant lines
[INFO] - 398 covered lines
[INFO] - 0 missed lines
[INFO] Submitting Coveralls data to API

[ERROR] Failed to execute goal org.eluder.coveralls:coveralls-maven-plugin:4.3.0:report (default-cli) on project solid: Execution default-cli of goal org.eluder.coveralls:coveralls-maven-plugin:4.3.0:report failed: A required class was missing while executing org.eluder.coveralls:coveralls-maven-plugin:4.3.0:report: javax/xml/bind/DatatypeConverter

trautonen/coveralls-maven-plugin#141
@bocytko bocytko requested a review from a team as a code owner February 14, 2025 23:33
@bocytko
Copy link
Member Author

bocytko commented Feb 15, 2025

👍

@danielrohe danielrohe added the minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call. label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants