Merge pull request #1657 from puncleV/make-retry-exception-constructo…

…r-public

(refactor) make RetryException constructor public

riptide-failsafe/README.md

@@ -77,6 +77,23 @@ RetryPolicy.<ClientHttpResponse>builder()
     .build();
 ```
 
+By default, you can use RetryException in your routes to retry the request:
+
+```java
+retryClient.get()
+    .dispatch(
+        series(), on(CLIENT_ERROR).call(
+            response -> {
+                if (specificCondition(response)) {
+                    throw new RetryException(response); // we will retry this one
+                }  else {
+                    throw new AnyOtherException(response); // we wont retry this one
+                }  
+            }
+        )
+    ).join()
+```
+
 Failsafe supports dynamically computed delays using a custom function.
 
 Riptide: Failsafe offers implementations that understand:

riptide-failsafe/src/main/java/org/zalando/riptide/failsafe/RetryException.java

@@ -11,7 +11,7 @@
 @API(status = STABLE)
 public final class RetryException extends HttpResponseException {
 
-    RetryException(final ClientHttpResponse response) throws IOException {
+    public RetryException(final ClientHttpResponse response) throws IOException {
         super("Retrying response", response);
     }
 

riptide-spring-boot-autoconfigure/src/test/java/org/zalando/riptide/autoconfigure/retry/FailsafeRetryTest.java

@@ -13,14 +13,17 @@
 import org.zalando.riptide.autoconfigure.MetricsTestAutoConfiguration;
 import org.zalando.riptide.autoconfigure.OpenTracingTestAutoConfiguration;
 import org.zalando.riptide.autoconfigure.RiptideClientTest;
+import org.zalando.riptide.failsafe.RetryException;
 
 import java.util.concurrent.CompletionException;
 
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.springframework.http.HttpStatus.Series.SERVER_ERROR;
+import static org.springframework.http.HttpStatus.Series.CLIENT_ERROR;
 import static org.springframework.test.web.client.ExpectedCount.times;
 import static org.springframework.test.web.client.match.MockRestRequestMatchers.requestTo;
 import static org.springframework.test.web.client.response.MockRestResponseCreators.withServerError;
+import static org.springframework.test.web.client.response.MockRestResponseCreators.withBadRequest;
 import static org.zalando.riptide.Bindings.on;
 import static org.zalando.riptide.Navigators.series;
 import static org.zalando.riptide.failsafe.RetryRoute.retry;
@@ -54,4 +57,17 @@ void shouldRetryForAtMostMaxRetriesTimes() {
 
         server.verify();
     }
+
+    @Test
+    void shouldRetryForCustomRetryException() {
+        server.expect(times(3), requestTo("http://retry-test")).andRespond(withBadRequest());
+
+
+        assertThrows(CompletionException.class,
+                () -> retryClient.get().dispatch(series(), on(CLIENT_ERROR).call(response -> {
+                    throw new RetryException(response);
+                })).join());
+
+        server.verify();
+    }
 }