Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix documentation for providing custom bean scenario #1546

Merged
merged 6 commits into from
Dec 6, 2023

Conversation

Semernitskaya
Copy link
Contributor

@Semernitskaya Semernitskaya commented Dec 5, 2023

Description

Fixed documentation for bean overriding process

Motivation and Context

I found that bean overriding description is not fully clear and can confuse Riptide users, especially challenging can be cases when Http client bean name can't be used as-is in the method name. I provided more detailed description and one additional example.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Not applicable since it is a documentation fix

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@fatroom
Copy link
Member

fatroom commented Dec 5, 2023

@Semernitskaya can you please merge main branch to get the build passing?

@fatroom
Copy link
Member

fatroom commented Dec 6, 2023

Thank you for the contribution!

@fatroom
Copy link
Member

fatroom commented Dec 6, 2023

👍

@fatroom fatroom merged commit 51d708c into zalando:main Dec 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants