Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added additional tests for failsafe logging #1548

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Added additional tests for failsafe logging #1548

merged 1 commit into from
Dec 5, 2023

Conversation

fatroom
Copy link
Member

@fatroom fatroom commented Dec 5, 2023 •
edited
Loading

Description

Motivation and Context

This test is required to reach coverage of 100%
Coverage drop was introduced by #1503

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@fatroom
Copy link
Member Author

fatroom commented Dec 5, 2023

👍

@fatroom fatroom merged commit 455a93d into main Dec 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whiskeysierra whiskeysierra Awaiting requested review from whiskeysierra whiskeysierra is a code owner

@lukasniemeier-zalando lukasniemeier-zalando Awaiting requested review from lukasniemeier-zalando lukasniemeier-zalando is a code owner

@Semernitskaya Semernitskaya Awaiting requested review from Semernitskaya

@dingxiangfei2009 dingxiangfei2009 Awaiting requested review from dingxiangfei2009 dingxiangfei2009 is a code owner

@Joyfolk Joyfolk Awaiting requested review from Joyfolk Joyfolk is a code owner

@gpradeepkrishna gpradeepkrishna Awaiting requested review from gpradeepkrishna gpradeepkrishna is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fatroom