Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move testTracer struct in tracingtest package and reuse it #3322

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Move testTracer struct in tracingtest package and reuse it #3322

wants to merge 4 commits into from
+82 −105

Conversation

RomanZavodskikh
Copy link
Member

This pull requests is split from #3318 to refactor change of testTracer to make it more reusable.

Roman Zavodskikh added 2 commits November 25, 2024 13:36
@RomanZavodskikh RomanZavodskikh added the minor no risk changes, for example new filters label Nov 25, 2024
@RomanZavodskikh RomanZavodskikh mentioned this pull request Nov 25, 2024
Open
AlexanderYastrebov
AlexanderYastrebov requested changes Nov 25, 2024
View reviewed changes
filters/scheduler/fifo_test.go Show resolved Hide resolved
tracing/tracingtest/mocktracer.go Outdated Show resolved Hide resolved
filters/scheduler/lifo_test.go Outdated Show resolved Hide resolved
@AlexanderYastrebov
Copy link
Member

👍

@RomanZavodskikh
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderYastrebov AlexanderYastrebov AlexanderYastrebov approved these changes

Assignees
No one assigned
Labels
minor no risk changes, for example new filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RomanZavodskikh @AlexanderYastrebov