dataclients/kubernetes: append predicates to routes of Ingress/RouteGroup having specific annotation #3328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MustafaSaber
added
the
major
…roup having specific annotation The main purpose of this change is to allow skipper operators to dynamically add predicates to routes based on annotations key-value pairs in Kubernetes resources (metadata.annotation). This provides more flexibility in routing configuration without modifying the core Ingress or RouteGroup definitions. Key changes: - Added KubernetesAnnotationPredicates option & `-kubernetes-annotation-predicates` flag for public hostnames, which can be specified multiple times. - Added KubernetesEastWestRangeAnnotationPredicates option & `-kubernetes-east-west-range-annotation-predicates` flag for internal hostnames, which can be specified multiple times. - Modified Ingress and RouteGroup clients to apply annotation predicates depending on the host - Added test cases for new functionality Run & test with ```sh ➜ ./bin/skipper -kubernetes -kubernetes-annotation-predicates="zalando.org/traffic-disabled=true=False()" -kubernetes-east-west-range-annotation-predicates="zalando.org/traffic-disabled=true=False()" ➜ #or ➜ ./bin/routesrv -kubernetes -kubernetes-annotation-predicates="zalando.org/traffic-disabled=true=False()" -kubernetes-east-west-range-annotation-predicates="zalando.org/traffic-disabled=true=False()" ``` Having both flags with same value will append configured predicates to all routes of Ingress/RouteGroup resources annotated with `zalando.org/traffic-disabled: true`, routes defined in: * The `spec.rules` section of Ingress resources. * Routes specified using the `zalando.org/skipper-routes` annotation of Ingress resources. * The `spec.routes` section of RouteGroup resources. Signed-off-by: Mustafa Abdelrahman <[email protected]>
MustafaSaber
force-pushed
the
apply-predicates-on-a-set-of-ingresses-with-annotation
branch
from
c71990f
to
5839d17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this change is to allow skipper operators to dynamically add predicates to routes based on annotations key-value pairs in Kubernetes resources (metadata.annotation). This provides more flexibility in routing configuration without modifying the core Ingress or RouteGroup definitions.
Key changes:
-kubernetes-annotation-predicatesflag for public hostnames, which can be specified multiple times.-kubernetes-east-west-range-annotation-predicatesflag for internal hostnames, which can be specified multiple times.Run & test with
Having both flags with same value will append configured predicates to all routes of Ingress/RouteGroup resources annotated with
zalando.org/traffic-disabled: true, routes defined in:spec.rulessection of Ingress resources.zalando.org/skipper-routesannotation of Ingress resources.spec.routessection of RouteGroup resources.