Skip to content

Commit

Permalink
fix(ci): to be re-inserted, temp CI test
Browse files Browse the repository at this point in the history
  • Loading branch information
bcm-at-zama committed Oct 2, 2024
1 parent b290fd0 commit 1f101ab
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 8 deletions.
14 changes: 9 additions & 5 deletions .github/workflows/concrete_python_test_macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,17 +118,21 @@ jobs:
cp $GITHUB_WORKSPACE/frontends/concrete-python/Makefile .
- name: Test
run: |
# - name: Test
# run: |

set -e
cd $TEST_TMP_DIR && . .testenv/bin/activate
KEY_CACHE_DIRECTORY=./KeySetCache PYTEST_MARKERS="not dataflow and not graphviz" make pytest-macos
# set -e
# cd $TEST_TMP_DIR && . .testenv/bin/activate
# KEY_CACHE_DIRECTORY=./KeySetCache PYTEST_MARKERS="not dataflow and not graphviz" make pytest-macos

- name: Test notebooks
run: |
set -e
cd $TEST_TMP_DIR && . .testenv/bin/activate
pwd
ls
ls ./scripts
ls ./scripts/jupyter
make test-notebooks-macos
- name: Cleanup host
Expand Down
4 changes: 2 additions & 2 deletions frontends/concrete-python/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,10 @@ process-benchmark-results-for-grafana:

test-notebooks:
eval $(shell make silent_cp_activate)
./scripts/jupyter/jupyter.sh
bash ./scripts/jupyter/jupyter.sh

test-notebooks-macos:
./scripts/jupyter/jupyter.sh
bash ./scripts/jupyter/jupyter.sh

# ==========
# Formatting
Expand Down
2 changes: 1 addition & 1 deletion frontends/concrete-python/tests/execution/test_matmul.py
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ def test_zero_matmul(bit_width, signed, helpers):
Test matmul where one of the operators is all zeros.
"""

# FIXME: it fails
# FIXME: https://github.com/zama-ai/concrete-internal/issues/879
is_mac = platform.system() == "Darwin"

if is_mac and (bit_width, signed) == (10, False):
Expand Down

0 comments on commit 1f101ab

Please sign in to comment.