feat(frontend-python): module run are scheduled and parallelized in a… #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BourgerieQuentin
force-pushed
the
module-auto-schedule-rebased
branch
from
0e73056
to
4f5070a
Compare
BourgerieQuentin
force-pushed
the
module-auto-schedule-rebased
branch
from
4f5070a
to
70998db
Compare
| self, | ||
| *args: Optional[Union[Value, Tuple[Optional[Value], ...]]], | ||
| ) -> Union[Value, Tuple[Value, ...]]: | ||
| ) -> Any: |
There was a problem hiding this comment.
Note if you have better way to force pyling to force return type to Union[Value, Tuple[Value, ...]]
There was a problem hiding this comment.
Hmm probably you have to do something in this spirit:
output = self._run(True, *args)
assert(isinstance(output, Union[Value, Tuple[Value, ...]])
And pylint will be happy after that ....
There was a problem hiding this comment.
Yeah, it's unfortunate that typing.overload doesn't support specifying overloads based on specific values.
youben11
reviewed
Nov 19, 2024
| self, | ||
| sync: bool, | ||
| *args: Optional[Union[Value, Tuple[Optional[Value], ...]]], | ||
| ) -> Union[Value, Tuple[Value, ...], Future]: |
There was a problem hiding this comment.
You can be more specific in the Future type
| self, | ||
| *args: Optional[Union[Value, Tuple[Optional[Value], ...]]], | ||
| ) -> Union[Value, Tuple[Value, ...]]: | ||
| ) -> Any: |
There was a problem hiding this comment.
Yeah, it's unfortunate that typing.overload doesn't support specifying overloads based on specific values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… worker pool