-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds comments to example contracts, improve example contracts documentation #570
Conversation
…rtAccount.sol, TestAsyncDecrypt.sol
Note: there is a dead links error for https://github.com/zama-ai/fhevm/blob/main/examples/README.md, however this will not be an error anymore once this PR will be merged. |
Firstly, can you rebase interactively and squash all your commits to get a unique clean commit instead of 14? |
1d5a124
to
339174f
Compare
@jatZama I managed to squash only a portion of them, for the remaining few I get the following error: Unable to squash. Squashing replays all commits up to the last one required for the squash. A merge commit cannot exist among those commits. |
how do you do the squash? |
45643bc
to
1217b9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for the updates!
@poppyseedDev
Could you merge this PR also into the x0.5 branch? Otherwise it won't be reflected in the documentation website, especially in the "see-all-tutorials.md" where the links to "Governor DAO" and "Decentralized ID" are dead.
Closes #555
Mentions #556