Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ns/feat/more integers #2063

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Ns/feat/more integers #2063

wants to merge 3 commits into from

Conversation

nsarlin-zama
Copy link
Contributor

@nsarlin-zama nsarlin-zama commented Feb 13, 2025

closes: please link all relevant issues

PR content/description

  • adds more integer types to the HL
  • adds a feature flag to reduce compilation times when they are not needed. Compilation in release mode of tfhe is 70s without the flag and 90s with on my laptop
  • this only adds new types for the rust and js API, the c_api could be done in a future PR.
  • I certainly need to add a paragraph in the doc about this, I push the PR without so that it can be reviewed now, but I will add it right after.

This change is Reviewable

@cla-bot cla-bot bot added the cla-signed label Feb 13, 2025
@nsarlin-zama nsarlin-zama force-pushed the ns/feat/more_integers branch 2 times, most recently from 70c663c to 9722398 Compare February 14, 2025 10:10
@nsarlin-zama nsarlin-zama force-pushed the ns/feat/more_integers branch 3 times, most recently from e635cab to b6aece8 Compare February 14, 2025 13:15
Copy link
Contributor

@tmontaigu tmontaigu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 26 files reviewed, 1 unresolved discussion (waiting on @IceTDrinker)


tfhe/src/high_level_api/integers/signed/static_.rs line 50 at r1 (raw file):

}

#[cfg(feature = "extended-types")]

I don't know if it is any better but we could have had

#[cfg(feature = "extended-types")]
pub use extended::*;

#[cfg(feature = "extended-types")]
mod extended {
//..
}

@nsarlin-zama nsarlin-zama force-pushed the ns/feat/more_integers branch 2 times, most recently from 4b12fd0 to 89a3828 Compare February 14, 2025 14:04
Copy link
Contributor Author

@nsarlin-zama nsarlin-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 26 files reviewed, 1 unresolved discussion (waiting on @IceTDrinker and @tmontaigu)


tfhe/src/high_level_api/integers/signed/static_.rs line 50 at r1 (raw file):

Previously, tmontaigu (tmontaigu) wrote…

I don't know if it is any better but we could have had

#[cfg(feature = "extended-types")]
pub use extended::*;

#[cfg(feature = "extended-types")]
mod extended {
//..
}

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants