-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ns/feat/more integers #2063
base: main
Are you sure you want to change the base?
Ns/feat/more integers #2063
Conversation
58062fe
to
7bf5356
Compare
70c663c
to
9722398
Compare
e635cab
to
b6aece8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 26 files reviewed, 1 unresolved discussion (waiting on @IceTDrinker)
tfhe/src/high_level_api/integers/signed/static_.rs
line 50 at r1 (raw file):
} #[cfg(feature = "extended-types")]
I don't know if it is any better but we could have had
#[cfg(feature = "extended-types")]
pub use extended::*;
#[cfg(feature = "extended-types")]
mod extended {
//..
}
4b12fd0
to
89a3828
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 26 files reviewed, 1 unresolved discussion (waiting on @IceTDrinker and @tmontaigu)
tfhe/src/high_level_api/integers/signed/static_.rs
line 50 at r1 (raw file):
Previously, tmontaigu (tmontaigu) wrote…
I don't know if it is any better but we could have had
#[cfg(feature = "extended-types")] pub use extended::*; #[cfg(feature = "extended-types")] mod extended { //.. }
Done.
89a3828
to
8819a9d
Compare
closes: please link all relevant issues
PR content/description
This change is