Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Github Token to Docker build process #157

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

chicco785
Copy link
Member

@chicco785 chicco785 commented Jan 27, 2025

Description

While not ideal, the current fledge-power docker build process relies on github to build plugins from zaphiro's private repositories. So we need a way to pass a token able to clone zaphiro's private repositories to the docker build.

Changes Made

  • Pass Github Token to Docker build process

Related Issues

Checklist

  • I have used a PR title that is descriptive enough for a release note.
  • I have tested these changes locally.
  • I have added appropriate tests or updated existing tests.
  • I have tested these changes on fledge
  • I have added appropriate documentation or updated existing documentation.

@chicco785 chicco785 force-pushed the test-pass-github-token branch from 934aa3a to 92c5840 Compare February 20, 2025 09:47
@chicco785 chicco785 added the feature This issue/PR relates to a feature request. label Feb 20, 2025
@chicco785 chicco785 changed the title Update docker.yaml Pass Github Token to Docker build process Feb 20, 2025
@chicco785
Copy link
Member Author

@gtauzin when merged, you will need to slightly change your workflow:

jobs:
  docker-build-fledge:
    uses: zaphiro-technologies/github-workflows/.github/workflows/docker.yaml
    with:
      docker-file: .docker/fledge/Dockerfile
      docker-context: .docker/fledge
      image-name: fledge
      go-cache: false
    secrets:
      token: ${{ secrets.REPO_PRIVATE_READ_PAT }}

@chicco785 chicco785 marked this pull request as ready for review February 20, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant