Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PDE-5395] feat(schema): Add meta field support for FieldSchema #883

Merged
merged 15 commits into from
Nov 25, 2024
Merged

[PDE-5395] feat(schema): Add meta field support for FieldSchema #883

merged 15 commits into from
Nov 25, 2024

Conversation

rnegron
Copy link
Member

@rnegron rnegron commented Oct 10, 2024 •
edited
Loading

Adds support for static input fields to via a new FieldMetaSchema. Note that the FieldMetaSchema only allows for primitive values (no nested objects).

@rnegron rnegron self-assigned this Oct 10, 2024
@rnegron rnegron marked this pull request as ready for review October 29, 2024 14:56
@rnegron rnegron requested a review from a team as a code owner October 29, 2024 14:56
kola-er
kola-er previously approved these changes Oct 29, 2024
View reviewed changes
FokkeZB
FokkeZB reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@FokkeZB FokkeZB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest dropping null - the more strict the better.

@rnegron rnegron requested a review from kola-er November 20, 2024 22:02
kola-er
kola-er previously approved these changes Nov 21, 2024
View reviewed changes
@rnegron rnegron merged commit 66dc9da into main Nov 25, 2024
14 checks passed
@rnegron rnegron deleted the PDE-5395 branch November 25, 2024 13:00
@kola-er kola-er mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FokkeZB FokkeZB FokkeZB approved these changes

@kola-er kola-er kola-er approved these changes

@cvanderkolk cvanderkolk Awaiting requested review from cvanderkolk

Assignees

@rnegron rnegron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rnegron @FokkeZB @kola-er @cvanderkolk