fix - npm test error #1102
fix - npm test error #1102
Conversation
Signed-off-by: Khaled Nassar <[email protected]>
| // </dirty-hack> | ||
| class NoClientIdError extends Error {} | ||
|
|
||
| const utils = (function () { |
There was a problem hiding this comment.
This does not look right, we should not need to copy the script around to test it, we didn't before (when it worked).
There was a problem hiding this comment.
I tried to import it by using const or import commands, but it won't work
keep in mind the last commit on this file (before my changes ) imports the file by using global.eval, and this doesn't import the utils function correctly, and that's what caused the problem
There was a problem hiding this comment.
I understand that it's broken now but copying does not seem to be the correct fix.
There was a problem hiding this comment.
Yeah, but could we use this as a temporary solution until we find a better way to import this file?
There was a problem hiding this comment.
IMO it would better to disable the test than merge this workaround (which is no longer testing the actual code but the copied one).
|
Closing, this is not the correct fix, there was no more activity, and there's a new PR (#1296). |
#1103