add eaglercraft as alternative, fix types again

zardoy · Sep 3, 2024 · 9e7711e · 9e7711e
1 parent 684261e
commit 9e7711e
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/README.MD b/README.MD
@@ -188,3 +188,4 @@ General:
 ### Alternatives
 
 - [https://github.com/ClassiCube/ClassiCube](ClassiCube - Better C# Rewrite) [DEMO](https://www.classicube.net/server/play/?warned=true)
+- [https://m.eaglercraft.com/](EaglerCraft) - Eaglercraft runnable on mobile (real Minecraft in the browser)
diff --git a/prismarine-viewer/viewer/lib/mesher/models.ts b/prismarine-viewer/viewer/lib/mesher/models.ts
@@ -410,7 +410,7 @@ export function getSectionGeometry (sx, sy, sz, world: World) {
     tiles: {},
     // todo this can be removed here
     signs: {},
-    isFull: true,
+    // isFull: true,
     highestBlocks: {},
     hadErrors: false
   }

diff --git a/prismarine-viewer/viewer/lib/mesher/shared.ts b/prismarine-viewer/viewer/lib/mesher/shared.ts
@@ -29,7 +29,7 @@ export type MesherGeometryOutput = {
   indices: number[],
   tiles: Record<string, BlockType>,
   signs: Record<string, any>,
-  isFull: boolean
+  // isFull: boolean
   highestBlocks: Record<string, { y: number, name: string }>
   hadErrors: boolean
 }
diff --git a/prismarine-viewer/viewer/lib/mesher/test/mesherTester.ts b/prismarine-viewer/viewer/lib/mesher/test/mesherTester.ts
@@ -41,7 +41,7 @@ export const setup = (version, initialBlocks: Array<[number[], string]>) => {
   reload()
 
   const getLights = () => {
-    return Object.fromEntries(getGeometry().faces.map(({ face, light }) => ([face, light * 15 - 2])))
+    return Object.fromEntries(getGeometry().faces.map(({ face, light }) => ([face, (light ?? 0) * 15 - 2])))
   }
 
   const setLight = (x: number, y: number, z: number, val = 0) => {
Original file line number	Diff line number	Diff line change
Expand Up		@@ -188,3 +188,4 @@ General:
		### Alternatives

		- [https://github.com/ClassiCube/ClassiCube](ClassiCube - Better C# Rewrite) [DEMO](https://www.classicube.net/server/play/?warned=true)
		- [https://m.eaglercraft.com/](EaglerCraft) - Eaglercraft runnable on mobile (real Minecraft in the browser)