Skip to content

Commit

Permalink
[IT-1826] Remove config rule for strides and strides-ampad (Sage-Bion…
Browse files Browse the repository at this point in the history
…etworks-IT#1110)

* Removing config rule for accounts that are not in our organizations to
  be consistent with the member accounts in the organizations.

* Ignore pre-commit warning "W2001 Parameter LocalCloudtrailBucket not used".
  • Loading branch information
zaro0508 authored Apr 2, 2024
1 parent 3855535 commit 571e58a
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 34 deletions.
22 changes: 5 additions & 17 deletions sceptre/strides-ampad-workflows/templates/aws-config.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
Description: Setup AWS config and rules
AWSTemplateFormatVersion: 2010-09-09
Metadata:
cfn-lint:
config:
ignore_checks:
- W2001
Parameters:
OperatorEmail:
Type: String
Expand Down Expand Up @@ -115,23 +120,6 @@ Resources:
LogGroupName: !Sub '/aws/config/${AWS::StackName}.log'
RetentionInDays: !Ref RetentionInDays

####### Cloudtrail Rules #######

# https://docs.aws.amazon.com/config/latest/developerguide/cloudtrail-enabled.html
CloudtrailEnabledAwsConfigRule:
Type: 'AWS::Config::ConfigRule'
DependsOn: ConfigConfigurationRecorder
Properties:
Description: Checks whether AWS CloudTrail is enabled.
InputParameters:
s3BucketName: !Ref LocalCloudtrailBucket
snsTopicArn: !Ref SNSConfigTopic
cloudWatchLogsLogGroupArn: !GetAtt LogsConfigLogGroup.Arn
Scope: {}
Source:
Owner: AWS
SourceIdentifier: CLOUD_TRAIL_ENABLED
MaximumExecutionFrequency: TwentyFour_Hours
Outputs:
S3ConfigBucket:
Value: !Ref S3ConfigBucket
Expand Down
22 changes: 5 additions & 17 deletions sceptre/strides/templates/aws-config.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
Description: Setup AWS config and rules
AWSTemplateFormatVersion: 2010-09-09
Metadata:
cfn-lint:
config:
ignore_checks:
- W2001
Parameters:
OperatorEmail:
Type: String
Expand Down Expand Up @@ -115,23 +120,6 @@ Resources:
LogGroupName: !Sub '/aws/config/${AWS::StackName}.log'
RetentionInDays: !Ref RetentionInDays

####### Cloudtrail Rules #######

# https://docs.aws.amazon.com/config/latest/developerguide/cloudtrail-enabled.html
CloudtrailEnabledAwsConfigRule:
Type: 'AWS::Config::ConfigRule'
DependsOn: ConfigConfigurationRecorder
Properties:
Description: Checks whether AWS CloudTrail is enabled.
InputParameters:
s3BucketName: !Ref LocalCloudtrailBucket
snsTopicArn: !Ref SNSConfigTopic
cloudWatchLogsLogGroupArn: !GetAtt LogsConfigLogGroup.Arn
Scope: {}
Source:
Owner: AWS
SourceIdentifier: CLOUD_TRAIL_ENABLED
MaximumExecutionFrequency: TwentyFour_Hours
Outputs:
S3ConfigBucket:
Value: !Ref S3ConfigBucket
Expand Down

0 comments on commit 571e58a

Please sign in to comment.