Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin astroid to <4 to avoid docs build failures #2796

Merged
merged 5 commits into from
Feb 4, 2025

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Feb 4, 2025

This PR adds an empty file to probe recent docs build failures. It should not be merged.

This PR adds astroid<4 to the docs dependencies, which allows the docs to build properly.

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Feb 4, 2025
@d-v-b d-v-b changed the title [do not merge] test recent doc build failures pin astroid to <4 to avoid docs build failures Feb 4, 2025
@d-v-b d-v-b marked this pull request as ready for review February 4, 2025 15:13
@d-v-b d-v-b requested a review from dstansby February 4, 2025 15:13
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Feb 4, 2025
@d-v-b
Copy link
Contributor Author

d-v-b commented Feb 4, 2025

closes #2797

@d-v-b
Copy link
Contributor Author

d-v-b commented Feb 4, 2025

pre-commit failure can be ignored. the spellchecker wants "astroid" to be changed to "asteroid".

@dstansby
Copy link
Contributor

dstansby commented Feb 4, 2025

Probably don't want pre-commit to be failing on all other PRs, so I added some config to ignore astroid. Otherwise 👍 , so I'll merge if CI passes to unblock CI on other PRs.

@dstansby dstansby enabled auto-merge (squash) February 4, 2025 21:20
@dstansby dstansby merged commit cd1f33d into zarr-developers:main Feb 4, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants