Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated main.py to add an exclude array for users #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated main.py to add an exclude array for users #1

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63e8256
Updated main.py to add an exclude array for users
Jun 6, 2019
92eaeb9
Merge branch 'master' into patch-1
zoidyzoidzoid Jun 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
from requests import post
from slackclient import SlackClient

EXCLUDE_USERS = [
'UC2PXG134'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should maybe put these in some sort of configuration file, since other folks are starting to use this bot on their own workspaces and potentially Slack user IDs could collide maybe? I also think including their username in a comment is useful, in case folks ask to get added/removed.

]

HITS = [
'guyz',
Expand Down Expand Up @@ -45,6 +48,8 @@ def process_message_event(client, event):
return
user = event['user']
if any(hit in text.lower() for hit in HITS):
if any(excludeUser.lower() in user.lower() for excludeUser in EXCLUDE_USERS):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could exit out even earlier in the function, since we don't need to check if they said something that triggers the bot's response, since it'll be faster and avoid the other work. I'd also suggest keeping the excluded users in a Python set instead of array, then we can just check if user.lower() in EXCLUDE_USERS.

return
client.api_call(
'chat.postEphemeral',
channel=channel,
Expand Down