remove duplicate nicegui dependencies #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodja
approved these changes
Jan 4, 2024
|
Oh, it broke the build: https://github.com/zauberzeug/learning_loop_node/actions/runs/7406821103/job/20151886075 |
|
I supposed it is needed then since nicegui is not a real dependency but just used as the docker container base and really it should not be. |
|
See updated pull request #7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many dependencies are already included in nicegui and have conflicting version with the ones used in nicegui 1.2.13 (which is currently used by the base_node.dockerfile and thus by all others based on it).
By removing the explicit dependencies here, we would avoid overwriting them and breaking something in nicegui.