SearchBox: Unify suggestions and input design #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
As we now have a custom component for the paper we can also show some content above the list. What do you think about adding some big buttons above the list to open features like "Current location", "Home", "School"/"Work" and "Last seen"? I've tried it but it didn't look good:
|
zbycz
reviewed
Dec 26, 2024
| export const OptionsPaper = styled(Paper)<PaperProps>` | ||
| background-color: ${({ theme }) => theme.palette.background.searchInput}; | ||
| -webkit-backdrop-filter: blur(35px); | ||
| backdrop-filter: blur(35px); |
There was a problem hiding this comment.
To consider: The custom component looks great on empty screen. Though i think, it shouldn't be transparent, when there is a sidebar open. Everything kinda melts together. Is it fixable?
This was referenced Dec 26, 2024
|
|
|
I checked it in both light and dark mode and IMHO it's OK 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #589 we agreed to make the suggestions transparent and add a gap to the input.
Screenshots
Accessibility
I'm unsure about the contrast it is probably too low for the secondary/gray labels