Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general: fix TooltipButton to stay open on desktop #879

Merged
merged 1 commit into from
Jan 9, 2025
Merged

general: fix TooltipButton to stay open on desktop #879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions src/components/utils/TooltipButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,17 +54,32 @@ export const TooltipButton = ({ tooltip, onClick, color }: Props) => {

useClickAwayListener(tooltipRef, hide, isMobile);

return (
const content = (
<StyledIconButton onClick={handleClick}>
<InfoOutlinedIcon fontSize="small" color={color} />
</StyledIconButton>
);

// There is a bug in MUI, passing `open={undefined}` prop to Tooltip makes it uninteractive TODO check again eg 6/2025, or report
return isMobile ? (
<Tooltip
arrow
title={tooltip}
placement="top"
open={mobileTooltipShown}
ref={tooltipRef}
>
{content}
</Tooltip>
) : (
<Tooltip
arrow
title={tooltip}
placement="top"
open={isMobile ? mobileTooltipShown : undefined}
//open={isMobile ? mobileTooltipShown : undefined} -- broken, see above
ref={tooltipRef}
>
<StyledIconButton onClick={handleClick}>
<InfoOutlinedIcon fontSize="small" color={color} />
</StyledIconButton>
{content}
</Tooltip>
);
};
Loading