-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Recursive verifier API #666
Draft
therealyingtong
wants to merge
24
commits into
endoscale
Choose a base branch
from
mock-ivc-verif
base: endoscale
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealyingtong
force-pushed
the
mock-ivc-verif
branch
from
September 27, 2022 12:53
2a42414
to
0e03446
Compare
[book] Add description of endoscaling and public input handling. Co-authored-by: Ying Tong Lai <[email protected]> Signed-off-by: Daira Hopwood <[email protected]>
therealyingtong
force-pushed
the
endoscale
branch
from
October 24, 2022 22:28
f1f824a
to
6a2ba5e
Compare
therealyingtong
commented
Nov 1, 2022
let verifier = VerifierCircuit::<'_, EpAffine, Challenge255<EpAffine>, _> { | ||
vk, | ||
proof: Value::known(proof), | ||
instances: &[], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feed in updated accumulator as public input
therealyingtong
force-pushed
the
mock-ivc-verif
branch
from
November 21, 2022 23:44
f5f9e51
to
e34a635
Compare
therealyingtong
force-pushed
the
mock-ivc-verif
branch
from
November 21, 2022 23:48
e34a635
to
0db551d
Compare
therealyingtong
force-pushed
the
mock-ivc-verif
branch
from
November 28, 2022 21:57
0db551d
to
0124fdd
Compare
daira
reviewed
Dec 9, 2022
// /// (e.g. in IPA, we can put challenges into witness) | ||
// type Witness; | ||
|
||
/// Read a previous instance (C, z), encoded as a public input to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
/// Read a previous instance (C, z), encoded as a public input to | |
/// Read previous instances [(C, z)], encoded as a public input to |
therealyingtong
force-pushed
the
endoscale
branch
3 times, most recently
from
January 24, 2023 18:46
75250e7
to
1af488a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #435. Based on #529.