Android rust build fix #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zancas
reviewed
Apr 6, 2022
| @@ -0,0 +1,56 @@ | |||
| ARG rust_ver=1.56 | |||
| FROM rust:${rust_ver}-slim-bullseye | |||
There was a problem hiding this comment.
Why are we using 'slim'? From this doc it seems like this is a space optimization?
There was a problem hiding this comment.
I don't remember what directed my decision, I believe it was over dependences and other containers I saw and got ideas from
zancas
reviewed
Apr 6, 2022
| docker build --tag zecwalletmobile/android:latest docker | ||
|
|
||
| # build rust library for android, used nightly build to rebuild core-librarys not there at compile time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated docker image and added another docker image to help in the compiling of rust for android