Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cisco theme #1977

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

thommorais
Copy link

This PR adds the a simple theme.

dark

This comment was marked as resolved.

@thommorais

This comment was marked as resolved.

@cla-bot cla-bot bot added the cla-signed label Feb 1, 2025

This comment was marked as resolved.

@notpeter

This comment was marked as resolved.

@thommorais

This comment was marked as resolved.

@notpeter

This comment was marked as resolved.

@thommorais

This comment was marked as resolved.

Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thommorais
Copy link
Author

@thommorais It looks like there are some issues with the structure of your theme files.

This is not a valid theme file: https://github.com/thommorais/zed-cisco-theme/blob/9a2b1ca50848095c6ef07649b37b504c06b71a06/themes/cisco-dark.json

And this theme file is empty: https://github.com/thommorais/zed-cisco-theme/blob/9a2b1ca50848095c6ef07649b37b504c06b71a06/themes/base.json

Here's an example of what the theme files should look like: https://github.com/zed-industries/zed/blob/70b1e0eec0f4118c15d908636b9a38591dcf43ea/assets/themes/one/one.json

Apologies—I forgot to build the theme, so the files you mentioned were in there bacause I plan to create a light version in the future, but for now, I’ve deleted them and added the build version to the root directory

@maxdeviant
Copy link
Member

maxdeviant commented Feb 7, 2025

@thommorais I think we're almost there.

This theme file needs to be inside of a themes directory: https://github.com/thommorais/zed-cisco-theme/blob/687bc688e073627ae88881aa6be4af60c736719c/cisco-theme.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants