-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cisco theme #1977
base: main
Are you sure you want to change the base?
Add Cisco theme #1977
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thommorais It looks like there are some issues with the structure of your theme files.
This is not a valid theme file: https://github.com/thommorais/zed-cisco-theme/blob/9a2b1ca50848095c6ef07649b37b504c06b71a06/themes/cisco-dark.json
And this theme file is empty: https://github.com/thommorais/zed-cisco-theme/blob/9a2b1ca50848095c6ef07649b37b504c06b71a06/themes/base.json
Here's an example of what the theme files should look like: https://github.com/zed-industries/zed/blob/70b1e0eec0f4118c15d908636b9a38591dcf43ea/assets/themes/one/one.json
Apologies—I forgot to build the theme, so the files you mentioned were in there bacause I plan to create a light version in the future, but for now, I’ve deleted them and added the build version to the root directory |
@thommorais I think we're almost there. This theme file needs to be inside of a |
This PR adds the a simple theme.