gpui: Add text alignment #24090
Merged
gpui: Add text alignment #24090
+112
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
|
Thank you! |
|
I have do a quick try it. But it is looks like not works. 🤔
|
|
This is cause by |
huacnlee
reviewed
Feb 3, 2025
| let mut glyph_origin = point( | ||
| aligned_origin_x( | ||
| origin, | ||
| align_width.unwrap_or(layout.width), |
There was a problem hiding this comment.
Here layout.width is the actually text width, not the line width.
So if the text is "hello", the layout.width be the width of the "hello".
huacnlee
reviewed
Feb 3, 2025
| window: &mut Window, | ||
| cx: &mut App, | ||
| ) -> Result<()> { | ||
| paint_line( | ||
| origin, | ||
| &self.layout.unwrapped_layout, | ||
| line_height, | ||
| align, | ||
| self.layout.wrap_width, |
There was a problem hiding this comment.
The whitespace_normal can works, because of the wrap_width have value.
This is by TextLayout to measured known_dimensions:
zed/crates/gpui/src/elements/text.rs
Line 287 in 1301c41
But if nowrap mode, the wrap_width is none.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a text property for controlling left, center, or right text alignment.
#8792 should stay open since this doesn't add support for
justify(which would require a much bigger change since this can just alter the origin of each line, but justify requires changing spacing, whereas justify requires changes to each platform's shaping code).Release Notes: