Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpui: Fix text alignment for non-wrapped lines #24117

Closed
wants to merge 2 commits into from
Closed

gpui: Fix text alignment for non-wrapped lines #24117

wants to merge 2 commits into from

Conversation

someone13574
Copy link
Contributor

Fixes #24090 (comment) and another problem which would cause text to be one glyph further to the left than it should.

@huacnlee, can you test this?

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 3, 2025
@huacnlee
Copy link
Contributor

huacnlee commented Feb 3, 2025

Haha, we are do the same thing.

#24116

@someone13574
Copy link
Contributor Author

Haha, we are do the same thing.

#24116

We can go with your PR. Can you include 5930d9d as well?

@someone13574
Copy link
Contributor Author

someone13574 commented Feb 3, 2025 •
edited
Loading

Before & after for 5930d9d

Before:
Screenshot from 2025-02-02 23-00-56

After:
Screenshot from 2025-02-02 22-59-42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@someone13574 @huacnlee