Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project panel: Support dropping files from finder #12880

Merged
merged 12 commits into from
Jun 13, 2024

Conversation

bennetbo
Copy link
Contributor

@bennetbo bennetbo commented Jun 11, 2024

Partially addresses #7386

Screen.Recording.2024-06-11.at.12.20.25.mov

Release Notes:

  • Added support for dropping files from the finder onto the project panel

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jun 11, 2024
@bennetbo bennetbo marked this pull request as ready for review June 11, 2024 10:29
@Angelk90
Copy link
Contributor

@bennetbo : Wouldn't it be better to put the words Open a project in the center of the panel.

@bennetbo
Copy link
Contributor Author

@bennetbo : Wouldn't it be better to put the words Open a project in the center of the panel.

@Angelk90 I am not a designer, but I think it's fine the way it is. Does not have to do anything with this PR by the way.

@Angelk90
Copy link
Contributor

@bennetbo : Open recent never opens for me, every time I open zed it always opens the latest project, so that thing never appears.

@bennetbo
Copy link
Contributor Author

@Angelk90 You're probably talking about #7759. Again, as far as I am aware this has nothing to do with this PR.

@bennetbo bennetbo self-assigned this Jun 13, 2024
@bennetbo bennetbo merged commit 38d9ee3 into main Jun 13, 2024
9 checks passed
@bennetbo bennetbo deleted the drop-external-files-project-panel branch June 13, 2024 18:48
ming900518 pushed a commit to ming900518/zed that referenced this pull request Jun 14, 2024
fallenwood pushed a commit to fallenwood/zed that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants