Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for images in Markdown previews #16192

Closed
wants to merge 33 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
a008b62
add markdown image preview
dovakin0007 Aug 14, 2024
e89f63f
fmt fix
dovakin0007 Aug 17, 2024
5e1befb
fix image not rendering side by side
dovakin0007 Aug 23, 2024
94b4efe
Merge branch 'zed-industries:main' into main
dovakin0007 Aug 29, 2024
425cd03
use Image Source to check if image is valid
dovakin0007 Aug 29, 2024
e2e71bb
test fixes
dovakin0007 Aug 31, 2024
3686ce7
fix image not rendering in table
dovakin0007 Sep 1, 2024
e1122d6
fix image not rendering together with text
dovakin0007 Sep 7, 2024
1097dab
fix
dovakin0007 Sep 7, 2024
ba105e1
fix
dovakin0007 Sep 7, 2024
4bc4741
fix local images not rendering
dovakin0007 Sep 8, 2024
067a906
init
dovakin0007 Sep 8, 2024
302b917
fix
dovakin0007 Sep 10, 2024
100b09d
Merge branch 'zed-industries:main' into main
dovakin0007 Sep 16, 2024
43697e2
removed unwanted code
dovakin0007 Sep 17, 2024
4f0ad6a
Merge branch 'zed-industries:main' into main
dovakin0007 Sep 17, 2024
128c555
fix
dovakin0007 Sep 17, 2024
2963ae1
Merge branch 'zed-industries:main' into main
dovakin0007 Sep 17, 2024
005956f
fmt fix
dovakin0007 Sep 17, 2024
cb16b35
Update markdown_renderer.rs
dovakin0007 Oct 1, 2024
33c7b89
Update markdown_renderer.rs
dovakin0007 Oct 1, 2024
c9401fc
renamed x
dovakin0007 Oct 1, 2024
27b46a2
fix
dovakin0007 Oct 1, 2024
65189ce
merge conflict fix
dovakin0007 Oct 3, 2024
ec36f15
Merge branch 'main' into main
dovakin0007 Oct 15, 2024
e500677
Update markdown_renderer.rs
dovakin0007 Oct 15, 2024
e149b39
nameing changes
dovakin0007 Oct 15, 2024
e45171f
Merge branch 'main' into main
dovakin0007 Oct 28, 2024
2c1eeee
test fix
dovakin0007 Oct 28, 2024
1de2b6e
Merge branch 'main' into main
dovakin0007 Nov 18, 2024
5a91d67
wip image fallback
dovakin0007 Nov 19, 2024
d985a6a
added fallback text
dovakin0007 Nov 21, 2024
4b0fceb
fmt fix
dovakin0007 Nov 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
renamed x
dovakin0007 committed Oct 1, 2024
commit c9401fc7feb214dac9a56c4be233d1e9ff84659c
4 changes: 2 additions & 2 deletions crates/markdown_preview/src/markdown_renderer.rs
Original file line number Diff line number Diff line change
@@ -391,7 +391,7 @@ fn render_markdown_text(
}
}
let workspace = cx.workspace.clone();
let x = div()
let element = div()
.child(
InteractiveText::new(
element_id,
@@ -430,7 +430,7 @@ fn render_markdown_text(
),
)
.into_any();
any_element.push(x);
any_element.push(element);
}
MarkdownParagraph::MarkdownImage(image) => {
let (link, source_range, image_source) = match image {