Allow configuring spacing of project panel entries

[mikesun]

Release Notes:

• Added project_panel.entry_spacing setting to configure spacing between entries in the project panel.

Comfortable (default)

  "project_panel": {
    "entry_spacing": "comfortable",

Standard

  "project_panel": {
    "entry_spacing": "standard",

[mikesun]

Any feedback/comments on this approach?

[notpeter]

Apologies on what may feel like bikeshedding, but I think if we're going to expose this as a setting, we should attempt to make it match terminal_line_height and buffer_line_height as much as possible:

zed/docs/src/configuring-zed.md

Lines 151 to 157 in 2a9d755

	- Description: The default line height for text in the editor.
	- Setting: `buffer_line_height`
	- Default: `"comfortable"`
	**Options**
	`"standard"`, `"comfortable"` or `{"custom": float}` (`1` is very compact, `2` very loose)

So:

1. Instead of entry_spacing maybe entry_height?
2. Instead of ['comfortable', 'compact'] maybe ['comfortable', 'standard']
3. Maybe support custom spacing too: e.g. {"custom": 1.25}

Any feedback/comments on this approach?

CC design: @iamnbutler / @danilo-leal

[danilo-leal]

Agree with matching the naming pattern we've been using for settings similar to this. I'm just not sure about "entry" as the word for it; feels like not be best one. I'd probably use item. So:

  "project_panel": {
    "item_spacing": "comfortable",

[mikesun]

@notpeter danilo-leal Sorry for the delayed response.

Apologies on what may feel like bikeshedding, but I think if we're going to expose this as a setting, we should attempt to make it match terminal_line_height and buffer_line_height as much as possible:

zed/docs/src/configuring-zed.md

Lines 151 to 157 in 2a9d755

	- Description: The default line height for text in the editor.
	- Setting: `buffer_line_height`
	- Default: `"comfortable"`
	**Options**
	`"standard"`, `"comfortable"` or `{"custom": float}` (`1` is very compact, `2` very loose)

So:

1. Instead of entry_spacing maybe entry_height?
2. Instead of ['comfortable', 'compact'] maybe ['comfortable', 'standard']
3. Maybe support custom spacing too: e.g. {"custom": 1.25}

So the issue is this isn't actually a height setting similar terminal_line_height and buffer_line_height where you can actually give a spacing value because the project panel items are rendered as list items. It's a bit of a hack that uses a negative pixel offset for the list item component:

zed/crates/ui/src/components/list/list_item.rs

Line 203 in da80fd3

ListItemSpacing::ExtraDense => this.py_neg_px(),

But naming-wise, I could rename it so?

1. Instead of entry_spacing, item_height
2. Instead of ['comfortable', 'compact'] maybe ['comfortable', 'standard']

Does that work? Happy to make those changes

[maxdeviant]

Agree with matching the naming pattern we've been using for settings similar to this. I'm just not sure about "entry" as the word for it; feels like not be best one. I'd probably use item. So:

  "project_panel": {
    "item_spacing": "comfortable",

I think we should keep it "entry", as that's the terminology we use elsewhere (both in the code and in our actions and such).

[maxdeviant]

Thank you!