Display toasts for successful or failed dev extension installs #22893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21237
Release Notes:
This is my first attempt at a github PR - please review and let me know if any issues with general approach or wording, or other changes needed!
I am emitting events from the dev extension install process, and subscribing to them from the workspace module (it can go elsewhere if more appropriate) to show toasts instead of silently failing, when installing a dev extension from the command palette or the extensions UI.
To test successful install toasts:
a) it will first popup with an initial autoclosing toast.
b) then ideally it will succeed with a complete autoclosing toast.
Extensions can take a few seconds to install, so there can be a wait for the second toast - it may be worth adding a timed loop or just change wording to say please wait?
Test manifest error toast
Test rustup error toast (the error first reported in this issue)
Note there are no changes for the 2nd part of this ticket mentioned by uncenter - unsure how to tackle that.