Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's be real. It's time to admit that having a nix package in the repo was an experiment and a failed one at that. After #21550, the build definitions were outdated for a month with no effort being made to improve the situation.
Nixpkgs has maintainers for the zed package willing to support building zed (only stable though), while trying to keep the build definitions in the repo up to date without team support is futile and will only create additional burden both on the zed team and the contributors, whose efforts would arguably be better spent working on different issues.
If someone really wants to run a nightly build of zed using nix, they could always do something similar to the approach I've tried in #22825. I've added an error pointing to it in place of the package with an intend to remove it later when it's reasonable to expect that anyone who is trying to use the package from the repo has seen it
A different solution would be for someone from the team to commit to supporting nightly builds using nix continuously, which I see as unlikely, seeing as that would probably slow down PRs and require contributors to know nix or for that team member to monitor PRs constantly
I've also taken the liberty to use nixpkgs-unstable ref for nixpkgs, as the dev shell is not nixos specific and thus updating nixpkgs should not be blocked on nixos-specific packages as well as updating to a maintained version of flake-compat
cc @SomeoneToIgnore @mrnugget
Release Notes: