Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: Compute and synchronize diffs from HEAD #23626

Merged
merged 49 commits into from
Feb 4, 2025
Merged

Conversation

cole-miller
Copy link
Contributor

@cole-miller cole-miller commented Jan 24, 2025

This PR builds on #21258 to make it possible to use HEAD as a diff base. The buffer store is extended to support holding multiple change sets, and collab gains support for synchronizing the committed text of files when any collaborator requires it.

Not implemented in this PR:

  • Exposing the diff from HEAD to the user
  • Decorating the diff from HEAD with information about which hunks are staged

test_random_multibuffer now fails first at SEED=13277, similar to the previous high-water mark, but with various bugs in the multibuffer logic now shaken out.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 24, 2025
@cole-miller cole-miller self-assigned this Jan 27, 2025
@cole-miller cole-miller force-pushed the cole/change-diff-base branch from 76bfcfa to 610f5dd Compare January 27, 2025 22:05
@cole-miller cole-miller enabled auto-merge (squash) January 27, 2025 22:05
@cole-miller cole-miller disabled auto-merge January 27, 2025 22:09
@cole-miller cole-miller changed the title git: Use HEAD as the base for buffer diffs git: Compute and synchronize diffs from HEAD Jan 30, 2025
@maxbrunsfeld maxbrunsfeld force-pushed the cole/change-diff-base branch from f52b22f to 3e9b19e Compare January 31, 2025 19:29
@cole-miller
Copy link
Contributor Author

Probobuf check is expected to fail due to not understanding message renames.

@cole-miller cole-miller merged commit 5704b50 into main Feb 4, 2025
13 of 14 checks passed
@cole-miller cole-miller deleted the cole/change-diff-base branch February 4, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants