gpui: Add platform-specific keystroke display #25651
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
maxdeviant
changed the title
nt8r
reviewed
Feb 28, 2025
Comment on lines
354
to
366
| fn open_with_system(&self, path: &Path) { | ||
| let executor = self.background_executor().clone(); | ||
| let path = path.to_owned(); | ||
| executor | ||
| .spawn(async move { | ||
| let _ = std::process::Command::new("xdg-open") | ||
| .arg(path) | ||
| .spawn() | ||
| .expect("Failed to open file with xdg-open"); | ||
| }) | ||
| .detach(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Don't hard-code shelling out to a program that isn't even listed as a dependency of the crate. The right way to do this is to use a library that understands mime associations (e.g. https://docs.rs/xdg-utils/latest/xdg_utils/). In the worst case the command should be configurable.
There was a problem hiding this comment.
i agree, i used this because it's standard command similar to open on macos (although might have to be explicitly installed on linux).
perhaps this is only a linux specific dependency which i can add.
should i create a separate pr for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21938
I think I accidentally closed #23979 while pulling the latest so I had to create a new branch for it.
Release Notes: