Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug fixes - ex30 fsm solution #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ctosullivan
Copy link

Hi there, really enjoyed the FSM chapter and exercise.

I have two minor bug fixes to propose for the solution to ex 30:

  • state functions which were meant to be returning the result of a function call weren't being called correctly
  • the test function wasn't initialising the starting state, resulting in the FSM reaching an error state incorrectly when it should have finished in the connected state

Many thanks,

Cormac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant