RFC: Allow topic extraction via json::decode() #443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Neverlord - I'm attempting to use
broker::format::json::v1::decode()
to decode Zeek events sent by external clients, but implemented outside of the Broker layer. The Broker WebSocket format defines the"topic"
a client publishes to, to be part of the top-level JSON object.This PR changes
decode()
to optionally support extracting the topic, too. Does this feel too ad-hoc? I realizedecode()
can decode non-events, too, so maybe adding a separate helper would be the better approach?It's this part from the internal/json_client.cc, but it has a parsed JSON representation available:
broker/libbroker/broker/internal/json_client.cc
Lines 140 to 142 in 5847b2a