Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add developer docs about zkg's internal use of directories #175

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

ckreibich
Copy link
Member

I'm putting together some developer docs since I'm hoping to find more time to get back to working on zkg.

@ckreibich ckreibich force-pushed the topic/christian/add-path-docs branch 2 times, most recently from 54e5e25 to 3b7399c Compare January 23, 2024 02:26
@ckreibich ckreibich force-pushed the topic/christian/add-path-docs branch from 3b7399c to a09560d Compare January 23, 2024 18:00
- A "stage". A stage is any place in which ``zkg`` actually installs a package
for running in Zeek. This can be the local Zeek installation, or locally below
``$STATEDIR/testing`` when testing a package. So "staging" here does not mean
"not yet live"; rather the opposite: it's closer to "any place where the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. I think that might help with the mind-twistedness I experience whenever I try to understand anything of the staging / installation flow.

Having it in the docs is good, but I wonder if we should do something in the code. "stage" and "staging" in the deployment sense have such a well established meaning that this deviation seems very unfortunate and confusing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's just my read of it btw, but I don't see any code where a stage would be transitioned to a deployment, so I think that interpretation is closest. And yeah, I'd be happy to change the code. Simply calling it an Installation might do it.

involved upon next use.

When ``zkg`` isn't in the middle of executing any commands, you can always
delete the scratch space without negatively affecting ``zkg``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's on your mind, inverting this behavior and introducing --keep-scratch / --keep-testing or some --keep-temporary wildcard would be less surprising.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, especially for scratch. zkg could no doubt clean up properly in there. And for testing it could at least clean up when the tests pass. (And it should be much better about pointing you at the trouble if they don't, but that's another one.)

@ckreibich ckreibich merged commit d736ab7 into master Jan 24, 2024
5 checks passed
@ckreibich ckreibich deleted the topic/christian/add-path-docs branch January 24, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants