Pull in btest when installing package manager
#191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts a24124d where we moved `btest` into a dev dependency which would not be installed by default. While this would have been unobservable for users getting their `zkg` via Zeek (which also provides `btest`), or who install `zkg` via `pipx` (which even previously would never have linked the pulled in `btest` into the prefix), it might break users installing via `pip` into a random prefix.
timwoj
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts a24124d where we moved
btestinto a dev dependency which would not be installed by default. While this would have been unobservable for users getting theirzkgvia Zeek (which also providesbtest), or who installzkgviapipx(which even previously would never have linked the pulled inbtestinto the prefix), it might break users installing viapipinto a random prefix.