arrow, tag_ret, obj_Ygush00, kytag06, nh: all OK #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magcius
reviewed
Oct 1, 2023
| @@ -414,7 +414,7 @@ def DolphinLib(lib_name, objects): | |||
| Object(NonMatching, "d/d_snap.cpp"), | |||
| Object(Matching, "d/d_point_wind.cpp"), | |||
| Object(NonMatching, "d/actor/d_a_agb.cpp"), | |||
| Object(NonMatching, "d/actor/d_a_arrow.cpp"), | |||
| Object(Matching, "d/actor/d_a_arrow.cpp", cflags=[*cflags_framework, "-sym off"]), | |||
There was a problem hiding this comment.
This should just be -sym off, right? cflags_rel already includes cflags_framework
There was a problem hiding this comment.
arrow isn't it a rel, it's an actor in main.dol.
If I do cflags=["-sym off"] it won't compile at all, it seems to replace all the flags with just "-sym off", instead of adding them.
There was a problem hiding this comment.
ah. we can fix that I suppose, but for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I switched arrow, tag_ret, and ygush to use the
-sym offcompiler flag. This might not be exactly what the original developers did but I think it's worth doing temporarily for the sake of making them match until someone figures out what MWCC is doing with implicit destructors.