Provide community favorites shortcut #385
Conversation
|
Thanks for the PR @naomiceron, pardon my delay in reviewing.
|
| display: block; | ||
| margin: 0 auto; | ||
| width: fit-content; | ||
| } | ||
|
|
||
| #focus-btn, #lofi-btn { |
There was a problem hiding this comment.
this should be a CSS class instead of two IDs
| @@ -667,6 +669,13 @@ $(function() { | |||
| } | |||
| }); | |||
|
|
|||
| // Handle community favorites click | |||
| $("#fav-btn").click(function(event) { | |||
There was a problem hiding this comment.
Can refactor away this button
|
Thank you! @shakeelmohamed, should I remove the community button entirely? I ask because of the second point
I will make the changes as soon as possible :) |
Yeah that makes sense to me |
|
@shakeelmohamed Do you still have any interest in having this implemented? I would be happy to work on it if you can think of buttons you would like :) |
|
@jbecker7 Hey welcome! Go for it, please read through all comments in this PR and look at the changes before submitting your own |
|
Closing due to no activity |
Motivation and Context
This adds a generalized concept of community favorites, which includes the existing focus shortcut and the new lofi girl shortcut.
Closes #374 (Add shortcuts for "community favorites")
Types of changes
Description
This change adds a shortcut for community favorites as a general concept, clicking it makes appear a shortcut for focus and a shortcut for lofi. Tested it on Safari and Chrome.
Final checklist: